Abhishek Rawat has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24055 )

Change subject: IMPALA-14763: Prevent admissiond OOM during request 
decompression
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24055/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24055/2//COMMIT_MSG@21
PS2, Line 21: new memory
            : tracker
New memtracker makes sense. Note, that even with this the Scheduler might also 
allocate some memory and potentially result in OOM. We should probably add 
memtrackers for biggest consumers. Might also make sense to fix the accounting 
for the process mem tracker - IMPALA-14499.


http://gerrit.cloudera.org:8080/#/c/24055/2/be/src/scheduling/admission-controller.cc
File be/src/scheduling/admission-controller.cc:

http://gerrit.cloudera.org:8080/#/c/24055/2/be/src/scheduling/admission-controller.cc@1766
PS2, Line 1766: !request.request.IsCompressed()
why do we only check the limit for uncompressed requests?



--
To view, visit http://gerrit.cloudera.org:8080/24055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I196455f445f0644d89467a23b4ec1f64f184f2db
Gerrit-Change-Number: 24055
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Wed, 04 Mar 2026 04:05:54 +0000
Gerrit-HasComments: Yes

Reply via email to