Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24064 )

Change subject: POC: create minimal Thrift object from Iceberg table in minimal 
topic mode
......................................................................


Patch Set 1:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24064/1/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java:

http://gerrit.cloudera.org:8080/#/c/24064/1/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@424
PS1, Line 424:     table.setIceberg_table(Utils.getTIcebergTable(this, 
ThriftObjectType.DESCRIPTOR_ONLY));
line too long (91 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/24064
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If037a855dc5d2c4292347b34ebe0221477eae2fe
Gerrit-Change-Number: 24064
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Tue, 03 Mar 2026 16:28:38 +0000
Gerrit-HasComments: Yes

Reply via email to