Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24061 )
Change subject: IMPALA-14776 (part 2): Fix miscellaneous socket leaks ...................................................................... IMPALA-14776 (part 2): Fix miscellaneous socket leaks There are various sockets leaks that are not associated with Impala clients: - Users of urlopen don't auto-close the socket - Direct use of sockets don't clean up the socket - Various tests that spin up test servers (e.g. statestore tests) don't close clients or server sockets. This fixes those various locations either with manual clean up or with-as constructs. For urlopen, this simplifies the import to always use the Python 3 package location, dropping support for Python 2. Testing: - Ran tests locally and verified that they stopped leaking sockets Change-Id: I8fd54fad18d6dbfb0f24ebd910f45cfed76c340a Reviewed-on: http://gerrit.cloudera.org:8080/24061 Reviewed-by: Michael Smith <[email protected]> Reviewed-by: Yida Wu <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M tests/benchmark/report_benchmark_results.py M tests/common/iceberg_rest_server.py M tests/common/network.py M tests/custom_cluster/test_custom_statestore.py M tests/custom_cluster/test_hs2.py M tests/custom_cluster/test_krpc_options.py M tests/custom_cluster/test_metastore_service.py M tests/custom_cluster/test_statestored_ha.py M tests/hs2/test_hs2.py M tests/hs2/test_json_endpoints.py M tests/statestore/test_statestore.py 11 files changed, 60 insertions(+), 54 deletions(-) Approvals: Michael Smith: Looks good to me, but someone else must approve Yida Wu: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/24061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8fd54fad18d6dbfb0f24ebd910f45cfed76c340a Gerrit-Change-Number: 24061 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
