Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24050 )
Change subject: IMPALA-14791: Fix crash in PlanToJson when sink was not executed ...................................................................... IMPALA-14791: Fix crash in PlanToJson when sink was not executed impala-http-handler.cc::SinkToJsonHelper had the assumption that we always have a TPlanNodeExecSummary for the sink, but it is not true. In some cases we don't have plan node exec summaries, e.g.: * CTAS query failed to create the target table, so execution did not start * Admission control rejected query execution This patch set fixes SinkToJsonHelper to work well in case of missing summaries. Testing: * e2e added with failing CTAS * custom tests added with failing CTAS and INSERT due to admission control Change-Id: I4fe6ed48d365a34380991f544e1ff628e95fa89e Reviewed-on: http://gerrit.cloudera.org:8080/24050 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/service/impala-http-handler.cc M tests/common/impala_test_suite.py M tests/custom_cluster/test_admission_controller.py M tests/webserver/test_web_pages.py 4 files changed, 89 insertions(+), 35 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24050 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4fe6ed48d365a34380991f544e1ff628e95fa89e Gerrit-Change-Number: 24050 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
