Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24052 )

Change subject: POC IMPALA-14792: Try avoiding Hadoop Path functions during 
Iceberg table loading
......................................................................


Patch Set 2:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24052/2/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java
File fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java:

http://gerrit.cloudera.org:8080/#/c/24052/2/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java@367
PS2, Line 367:     if (contentFilePathStr.startsWith(tablePathStr_) && 
contentFilePathStr.charAt(tablePathStr_.length()) == '/') {
line too long (115 > 90)


http://gerrit.cloudera.org:8080/#/c/24052/2/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java@378
PS2, Line 378:           throw new TableLoadingException(String.format("Failed 
to load Iceberg datafile " +
line too long (92 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/24052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idce89117195e0fa64fdd6a6c576bce09ec2e75ea
Gerrit-Change-Number: 24052
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Sat, 28 Feb 2026 16:23:33 +0000
Gerrit-HasComments: Yes

Reply via email to