Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23991 )
Change subject: IMPALA-14764 (part 2): Fix LLVM's run-clang-tidy.py stderr handling ...................................................................... IMPALA-14764 (part 2): Fix LLVM's run-clang-tidy.py stderr handling For some reason, LLVM's run-clang-tidy.py captures the stderr from Clang Tidy and outputs it to stdout. The important output about issues goes to stdout. The output to stderr is mostly garbage like "70 warnings generated". To avoid that pollution, this modifies the script to send the stderr output to stderr (which we only output if there is an actual error running clang-tidy itself). Testing: - Ran bin/run_clang_tidy.sh on Ubuntu 20 / 22 Change-Id: I6ae90fb12dc222f8fb38b8e563617216ce806f0f Reviewed-on: http://gerrit.cloudera.org:8080/23991 Reviewed-by: Joe McDonnell <[email protected]> Tested-by: Joe McDonnell <[email protected]> --- M bin/llvm/run-clang-tidy.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Joe McDonnell: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/23991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6ae90fb12dc222f8fb38b8e563617216ce806f0f Gerrit-Change-Number: 23991 Gerrit-PatchSet: 8 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
