ji chen has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23793 )

Change subject: IMPALA-14092 Part3: Enable predicate pushdown for paimon table.
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23793/7/fe/src/main/java/org/apache/impala/planner/paimon/ImpalaExprConverter.java
File fe/src/main/java/org/apache/impala/planner/paimon/ImpalaExprConverter.java:

http://gerrit.cloudera.org:8080/#/c/23793/7/fe/src/main/java/org/apache/impala/planner/paimon/ImpalaExprConverter.java@176
PS7, Line 176:       SlotRef attribute = 
extractSlotRef(isNullPredicate.getChild(0));
             :       int index = getAttributeFieldIndex(attribute);
             :       if (!isNullPredicate.isNotNull()) {
             :         return builder_.isNull(index);
             :       } else
> Even if we have string_col LIKE 'asdf%xyz', we could push down startsWith(i
Done


http://gerrit.cloudera.org:8080/#/c/23793/7/fe/src/main/java/org/apache/impala/planner/paimon/ImpalaExprConverter.java@182
PS7, Line 182:       }
             :     } else if (filter instanceof InPredicate) {
             :       InPredicate in = (InPredicate) filter;
             :       SlotRef
> Even if we have string_col LIKE 'asdf%xyz', we could push down endsWith(ind
Thank you, have updated the implementation,the new implementation support 
'asdf%xyz' pattern, and also support REGEXP/RLIKE, by using regular expressions 
matching for replace original implementation.



--
To view, visit http://gerrit.cloudera.org:8080/23793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee07fa35de8381121a20b2976d6424626d705483
Gerrit-Change-Number: 23793
Gerrit-PatchSet: 8
Gerrit-Owner: ji chen <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: ji chen <[email protected]>
Gerrit-Comment-Date: Thu, 19 Feb 2026 00:56:00 +0000
Gerrit-HasComments: Yes

Reply via email to