Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23924 )
Change subject: IMPALA-14102: [part 3] Modified LoptOptimizeJoinRule with Impala changes ...................................................................... Patch Set 6: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/23924/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java: http://gerrit.cloudera.org:8080/#/c/23924/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@95 PS6, Line 95: 1.41 nit: looking at that jira it was fixed in 1.39 http://gerrit.cloudera.org:8080/#/c/23924/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@1930 PS6, Line 1930: public static boolean swapInputs(RelMetadataQuery mq, LoptMultiJoin multiJoin, > Good suggestion. I think it is available. But I'd rather get this patch i Ack -- To view, visit http://gerrit.cloudera.org:8080/23924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I168ae903934c5c74520a22605e73f71dc0a9d549 Gerrit-Change-Number: 23924 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 16 Feb 2026 22:45:19 +0000 Gerrit-HasComments: Yes
