Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23814 )

Change subject: IMPALA-14646: StorageDescriptor normalization should deal with 
parameters
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23814/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java:

http://gerrit.cloudera.org:8080/#/c/23814/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2344
PS2, Line 2344: previousSD.isSetStoredAsSubDirectories()
nit: There is no need to check this after normalizeStorageDescriptor (line 2385)



--
To view, visit http://gerrit.cloudera.org:8080/23814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a9fcf2d60a41e9669d49412d49a2416c13d17bc
Gerrit-Change-Number: 23814
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Fri, 09 Jan 2026 17:33:33 +0000
Gerrit-HasComments: Yes

Reply via email to