Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23831 )
Change subject: IMPALA-14460: Keep http connections open in impala-shell ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23831/3/shell/impala_shell/ImpalaHttpClient.py File shell/impala_shell/ImpalaHttpClient.py: http://gerrit.cloudera.org:8080/#/c/23831/3/shell/impala_shell/ImpalaHttpClient.py@424 PS3, Line 424: __reuse_connection The original code was checking if the connection is open before closing it - shouldn't the new code do the same? I would probably move this back to the start of sendRequestHeaders to create a new connection in case of retry_because_401 too -- To view, visit http://gerrit.cloudera.org:8080/23831 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iafb3fc39817e93c691cd993902c6d939a7235a03 Gerrit-Change-Number: 23831 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Farkas <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 09 Jan 2026 16:38:09 +0000 Gerrit-HasComments: Yes
