Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23666 )
Change subject: WIP: do not review, Test with hopefully 1 jenkins error ...................................................................... Patch Set 20: (61 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23666/20/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/23666/20/be/src/service/query-options.h@394 PS20, Line 394: QUERY_OPT_FN(calcite_join_test_1, CALCITE_JOIN_TEST_1, TQueryOptionLevel::REGULAR) \ line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/be/src/service/query-options.h@395 PS20, Line 395: QUERY_OPT_FN(calcite_join_test_2, CALCITE_JOIN_TEST_2, TQueryOptionLevel::REGULAR) \ line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/PrunedPartitionHelper.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/PrunedPartitionHelper.java: http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/PrunedPartitionHelper.java@109 PS20, Line 109: nonPartitionedCalciteConjunct_ = RexUtil.flatten(rexBuilder, simplifier.simplify(tmpCalciteConjunct)); line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java: http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@95 PS20, Line 95: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaLoptOptimizeExtension.class.getName()); line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@114 PS20, Line 114: RuntimeFilterReductionContext leftContext = createRuntimeFilterReductionContext(condition, adjust, line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@119 PS20, Line 119: RuntimeFilterReductionContext rightContext = createRuntimeFilterReductionContext(condition, adjust, line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@130 PS20, Line 130: RelOptCost totalPreJoinNonSwapCost = leftSideWithFilterCost.plus(rightSideWithoutFilterCost); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@131 PS20, Line 131: RelOptCost totalJoinNonSwapCost = totalPreJoinNonSwapCost.plus(ImpalaRelMdNonCumulativeCost.getJoinCost(leftSide, rightSide, mq)); line too long (134 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@132 PS20, Line 132: RelOptCost totalPreJoinSwapCost = leftSideWithoutFilterCost.plus(rightSideWithFilterCost); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@134 PS20, Line 134: RelOptCost totalJoinSwapCost = totalPreJoinSwapCost.plus(ImpalaRelMdNonCumulativeCost.getJoinCost(rightSide, leftSide, mq)); line too long (128 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@138 PS20, Line 138: private static boolean swapBitSides(ImmutableBitSet bitSet, boolean adjust, LoptJoinTree rightTree, RelNode join) { line too long (117 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@152 PS20, Line 152: startOfRightSideFields += multiJoin.getInputs().get(i).getRowType().getFieldList().size(); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@154 PS20, Line 154: int endOfRightSideFields = startOfRightSideFields + multiJoin.getInputs().get(factor).getRowType().getFieldList().size(); line too long (125 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@156 PS20, Line 156: return bitSet.nth(0) >= startOfRightSideFields && bitSet.nth(0) < endOfRightSideFields; line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@168 PS20, Line 168: for (RexNode andCondition : andConditions) { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@179 PS20, Line 179: ImpalaRelColumnOrigin leftOrigin = (ImpalaRelColumnOrigin) mq.getColumnOrigin(leftSide, leftIndex); line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@180 PS20, Line 180: ImpalaRelColumnOrigin rightOrigin = (ImpalaRelColumnOrigin) mq.getColumnOrigin(rightSide, rightIndex); line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@211 PS20, Line 211: RuntimeFilterInfo runtimeFilterInfo = rel.getCluster().getPlanner().getContext().unwrap(RuntimeFilterInfo.class); line too long (117 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@212 PS20, Line 212: runtimeFilterInfo.inputRefs_ = getInputRefsForContext(rel, runtimeFilterInfo.inputRefs_, 0); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@221 PS20, Line 221: RuntimeFilterInfo runtimeFilterInfo = join.getCluster().getPlanner().getContext().unwrap(RuntimeFilterInfo.class); line too long (120 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@222 PS20, Line 222: List<RexNode> andConditions = ExprConjunctsConverter.getAndConjuncts(join.getCondition()); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@224 PS20, Line 224: RuntimeFilterReductionContext context = createRuntimeFilterReductionContext(andConditions.get(0), false, line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@234 PS20, Line 234: RuntimeFilterInfo runtimeFilterInfo = rel.getCluster().getPlanner().getContext().unwrap(RuntimeFilterInfo.class); line too long (117 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@240 PS20, Line 240: runtimeFilterInfo.inputRefs_ = getInputRefsForContext(rel, runtimeFilterInfo.inputRefs_, i); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@267 PS20, Line 267: private static ImmutableBitSet getInputRefsForContext(RelNode rel, ImmutableBitSet currentSet, int i) { line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@275 PS20, Line 275: return ImmutableBitSet.range(rel.getInputs().get(0).getRowType().getFieldList().size()); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@287 PS20, Line 287: return currentSet.union(RelOptUtil.InputFinder.bits(((Filter) rel).getCondition())); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@289 PS20, Line 289: throw new RuntimeException("Unknown RelNodeType: " + ImpalaPlanRel.getRelNodeType(rel)); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@337 PS20, Line 337: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeExtension.java@349 PS20, Line 349: public final Map<TableScan, RuntimeFilterReductionContext> reductionMap_ = new HashMap<>(); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java: http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@154 PS20, Line 154: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaLoptOptimizeJoinRule.class.getName()); line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@210 PS20, Line 210: ImpalaLoptOptimizeExtension.RuntimeFilterInfo runtimeFilterInfo = multiJoinRel.getCluster().getPlanner().getContext().unwrap(ImpalaLoptOptimizeExtension.RuntimeFilterInfo.class); line too long (182 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@211 PS20, Line 211: if (runtimeFilterInfo != null && runtimeFilterInfo.queryOptions_ != null && runtimeFilterInfo.queryOptions_.calcite_join_test_2) { line too long (134 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@859 PS20, Line 859: ImpalaLoptOptimizeExtension.RuntimeFilterInfo runtimeFilterInfo = multiJoin.getMultiJoinRel().getCluster().getPlanner().getContext().unwrap(ImpalaLoptOptimizeExtension.RuntimeFilterInfo.class); line too long (203 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@860 PS20, Line 860: if (runtimeFilterInfo != null && runtimeFilterInfo.queryOptions_ != null && runtimeFilterInfo.queryOptions_.calcite_join_test_2) { line too long (140 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@1222 PS20, Line 1222: ImpalaLoptOptimizeExtension.RuntimeFilterInfo runtimeFilterInfo = multiJoin.getMultiJoinRel().getCluster().getPlanner().getContext().unwrap(ImpalaLoptOptimizeExtension.RuntimeFilterInfo.class); line too long (199 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@1224 PS20, Line 1224: costPushDown = ImpalaLoptOptimizeExtension.getCumulativeCost(pushDownTree.getJoinTree(), mq); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@1228 PS20, Line 1228: ImpalaLoptOptimizeExtension.RuntimeFilterInfo runtimeFilterInfo = multiJoin.getMultiJoinRel().getCluster().getPlanner().getContext().unwrap(ImpalaLoptOptimizeExtension.RuntimeFilterInfo.class); line too long (199 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@1240 PS20, Line 1240: ImpalaLoptOptimizeExtension.RuntimeFilterInfo runtimeFilterInfo = multiJoin.getMultiJoinRel().getCluster().getPlanner().getContext().unwrap(ImpalaLoptOptimizeExtension.RuntimeFilterInfo.class); line too long (199 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@1241 PS20, Line 1241: if (runtimeFilterInfo != null && runtimeFilterInfo.queryOptions_ != null && runtimeFilterInfo.queryOptions_.calcite_join_test_1) { line too long (136 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@2064 PS20, Line 2064: if (ImpalaLoptOptimizeExtension.swapInputs(mq, multiJoin, left, right, condition, rexBuilder, fullAdjust)) { line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@2362 PS20, Line 2362: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@2376 PS20, Line 2376: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortRemoveConstantKeysRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortRemoveConstantKeysRule.java: http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortRemoveConstantKeysRule.java@92 PS20, Line 92: return false; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelColumnOrigin.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelColumnOrigin.java: http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelColumnOrigin.java@27 PS20, Line 27: private final TableScan tableScan_; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdColumnOrigins.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdColumnOrigins.java: http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdColumnOrigins.java@69 PS20, Line 69: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaRelMdColumnOrigins.class.getName()); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdColumnOrigins.java@88 PS20, Line 88: return mq.getColumnOrigins(rel.getInput(), rel.getGroupSet().asList().get(iOutputColumn)); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdColumnOrigins.java@203 PS20, Line 203: public @Nullable Set<RelColumnOrigin> getColumnOrigins(TableModify rel, RelMetadataQuery mq, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdColumnOrigins.java@311 PS20, Line 311: private static @Nullable Set<RelColumnOrigin> getMultipleColumns(RexNode rexNode, RelNode input, line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdNonCumulativeCost.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdNonCumulativeCost.java: http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdNonCumulativeCost.java@34 PS20, Line 34: import org.apache.impala.calcite.rules.ImpalaLoptOptimizeExtension.RuntimeFilterReductionContext; line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdNonCumulativeCost.java@84 PS20, Line 84: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdNonCumulativeCost.java@115 PS20, Line 115: RuntimeFilterInfo runtimeFilterInfo = scan.getCluster().getPlanner().getContext().unwrap(RuntimeFilterInfo.class); line too long (118 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java: http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java@94 PS20, Line 94: this.planner_ = new VolcanoPlanner(ImpalaCost.FACTORY, new ImpalaLoptOptimizeExtension.RuntimeFilterInfo(analysisResult.getAnalyzer().getQueryOptions())); line too long (158 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java@108 PS20, Line 108: this.planner_ = new VolcanoPlanner(ImpalaCost.FACTORY, new ImpalaLoptOptimizeExtension.RuntimeFilterInfo(null)); line too long (116 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java File java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java: http://gerrit.cloudera.org:8080/#/c/23666/20/java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java@69 PS20, Line 69: protected static final Logger LOG = LoggerFactory.getLogger(TestReduceExprShuttle.class.getName()); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/23666/20/tests/query_test/test_runtime_filters.py File tests/query_test/test_runtime_filters.py: http://gerrit.cloudera.org:8080/#/c/23666/20/tests/query_test/test_runtime_filters.py@208 PS20, Line 208: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23666/20/tests/query_test/test_runtime_filters.py@208 PS20, Line 208: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/20/tests/util/test_file_parser.py File tests/util/test_file_parser.py: http://gerrit.cloudera.org:8080/#/c/23666/20/tests/util/test_file_parser.py@112 PS20, Line 112: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23666/20/tests/util/test_file_parser.py@112 PS20, Line 112: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/20/tests/util/test_file_parser.py@332 PS20, Line 332: def replace_calcite_planner_parsed_sections(parsed_sections, override_prefix): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/23666/20/tests/util/test_file_parser.py@341 PS20, Line 341: , flake8: E231 missing whitespace after ',' -- To view, visit http://gerrit.cloudera.org:8080/23666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4af2efcf8d8a6038ad67aa7ef5da57d8d0f8a2bc Gerrit-Change-Number: 23666 Gerrit-PatchSet: 20 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 08 Jan 2026 23:35:00 +0000 Gerrit-HasComments: Yes
