Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/23569 )
Change subject: IMPALA-14507: Register column-level privilege requests for INSERT ...................................................................... Patch Set 16: > Patch Set 16: Verified-1 > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12881/ This failed tests/authorization/test_ranger.py::TestRangerWithCalcite::test_view_on_view_all_configs. The reason is that given a SELECT query against a view v2 defined on another view v1, if v2's table property 'Authorized' is set to 'false', then we would have the following privilege requests registered (listed in the order according to which they are registered) when we use Calcite as the planner. - AuthorizableTable v2. - AuthorizableColumn's for referenced columns in v1. - AuthorizableTable v1. - AuthorizableColumn's for referenced columns in v2. It could be seen that AuthorizableColumn's for referenced columns in v1 are registered before AuthorizableTable for v1, and therefore this would fail the Preconditions check in patch set 16. The Preconditions check in patch set 16 seems to be too restrictive. I will try to come up with a relaxed Preconditions check in the next patch. -- To view, visit http://gerrit.cloudera.org:8080/23569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ef61801d3b394c56702b193c250492a62b111df Gerrit-Change-Number: 23569 Gerrit-PatchSet: 16 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 08 Jan 2026 23:08:41 +0000 Gerrit-HasComments: No
