Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22926 )
Change subject: IMPALA-14574: Lower memory estimate by analyzing PipelineMembership ...................................................................... Patch Set 15: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22926/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22926/14//COMMIT_MSG@92 PS14, Line 92: scale 10. No major regression is observed. > I thought no spill happen before and after the patch. But I check again jus It'd be nice to look at whether there's something unique about query 78. Maybe we're under-estimating minimum memory for an operator. http://gerrit.cloudera.org:8080/#/c/22926/14/fe/src/main/java/org/apache/impala/planner/PipelineBasedMemEstimator.java File fe/src/main/java/org/apache/impala/planner/PipelineBasedMemEstimator.java: http://gerrit.cloudera.org:8080/#/c/22926/14/fe/src/main/java/org/apache/impala/planner/PipelineBasedMemEstimator.java@60 PS14, Line 60: > The map value, PipeMem object, memorize the originating fragment where the Ack -- To view, visit http://gerrit.cloudera.org:8080/22926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba4f40993d8360bfdc1eb592a626e285dfed1627 Gerrit-Change-Number: 22926 Gerrit-PatchSet: 15 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 07 Jan 2026 01:14:27 +0000 Gerrit-HasComments: Yes
