Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23226 )
Change subject: IMPALA-14460: Keep http connections open in impala-shell ...................................................................... Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/23226/18/shell/impala_shell/ImpalaHttpClient.py File shell/impala_shell/ImpalaHttpClient.py: http://gerrit.cloudera.org:8080/#/c/23226/18/shell/impala_shell/ImpalaHttpClient.py@433 PS18, Line 433: print('Cookies expired, restarting authentication...', file=sys.stderr) This becomes more complicated to trigger. If we re-use a connection, then we don't seem to need to repeat authentication. It actually breaks the test I added in https://gerrit.cloudera.org/c/22462/28/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java because there's no longer a cookie authentication failure. I think I can still trigger it, but I need to add a load balancer that gets restarted in the middle to force it to reconnect. -- To view, visit http://gerrit.cloudera.org:8080/23226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7a6c4f175cceca80f530b4d4355316d588730f0 Gerrit-Change-Number: 23226 Gerrit-PatchSet: 18 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 06 Jan 2026 22:25:12 +0000 Gerrit-HasComments: Yes
