Hello Quanlong Huang, Riza Suminto, Yida Wu, Peter Rozsa, Mihaly Szjatinya, Joe
McDonnell, Csaba Ringhofer, Michael Smith,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23818
to look at the new patch set (#4).
Change subject: [WIP] IMPALA-13679: Fix ASAN Failure in Workload Management
Tests
......................................................................
[WIP] IMPALA-13679: Fix ASAN Failure in Workload Management Tests
The TickerSecondsBool class defined in ticker.h is used to
process queued completed queries at specified intervals.
This class references variables defined outside of it. The
workload management code never properly shuts down this
ticker resulting in it sometimes, during shutdown, to
access variables that have already been released.
Removes the Ticker class leveraging the available
primitives of the std::condition_variable type.
The Ticker class was originally developed to avoid spurious
wakeups of a std::condition_variable, but the functionality
provided by the Ticker class can be eliminated by leveraging
the built in functionality of std::condition_variable.
In the workload-management-worker.cc file, adds the static
keyword to variables that are intended to be used only in
that file.
Testing
* workload management custom cluster tests passed locally
Change-Id: I9a29f4f788cf7259c263a17272e86acdda5caa77
---
M be/src/service/impala-server.h
M be/src/service/workload-management-worker.cc
M be/src/util/CMakeLists.txt
D be/src/util/ticker-test.cc
D be/src/util/ticker.h
5 files changed, 17 insertions(+), 305 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/23818/4
--
To view, visit http://gerrit.cloudera.org:8080/23818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a29f4f788cf7259c263a17272e86acdda5caa77
Gerrit-Change-Number: 23818
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Mihaly Szjatinya <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
