Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23811 )
Change subject: IMPALA-14641: Add detailed operation page for Catalogd operations ...................................................................... Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/23811/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23811/2//COMMIT_MSG@12 PS2, Line 12: - Execution timeline with event timestamps > I am a bit concerned about storing this, especially for already finished re I think it's a good idea after all to deal with the Thrift request in a follow-up JIRA. Removed all the changes related to thrift req from this patch. http://gerrit.cloudera.org:8080/#/c/23811/2/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java File fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java: http://gerrit.cloudera.org:8080/#/c/23811/2/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@188 PS2, Line 188: String clientIp = "unknown"; > It seems wasteful to me to do this when the record is added, as probably th Removed thrift req changes from the patch as we'll do it in a follow-up JIRA http://gerrit.cloudera.org:8080/#/c/23811/2/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@189 PS2, Line 189: String coordinator = "unknown"; > The request was originally passed as a byte array, its could be saved there Done http://gerrit.cloudera.org:8080/#/c/23811/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/23811/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@670 PS2, Line 670: > Adding the timeline only at the end limits it usefulness - I didn't think i Thanks for the tip, we're now using an EventSequence reference to get the timeline in real-time whenever /operation_detail page is accessed. http://gerrit.cloudera.org:8080/#/c/23811/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@682 PS2, Line 682: Thrift() > This should be generally null when an exception was thrown. Done http://gerrit.cloudera.org:8080/#/c/23811/2/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/23811/2/tests/webserver/test_web_pages.py@1088 PS2, Line 1088: test_catalog_operation_detail_endpoint > It would be also useful to test long running DDL that is still running and Done -- To view, visit http://gerrit.cloudera.org:8080/23811 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib80ce3b5873672065b04b00a21d3419a1db0969c Gerrit-Change-Number: 23811 Gerrit-PatchSet: 3 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Mon, 05 Jan 2026 18:19:52 +0000 Gerrit-HasComments: Yes
