Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22742 )
Change subject: IMPALA-13879: Support Systemd in linux packaging ...................................................................... Patch Set 1: (1 comment) > Patch Set 1: > > > Patch Set 1: > > > > (4 comments) > > Hi quanlong, there are serval 'type=' of systemd > service:https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html#Type=, > and 'Type=exec' is the most recommanded one. > > If we choose use 'Type=exec', we should set environment variables in a more > directly way, so I assume impala admin will manually modify the JAVA_HOME and > others to a suitable value. > > But if we want a more smart way to set the environment variables, we maybe > should change the type to 'Type=forking' like doris > (https://github.com/apache/doris/blob/3.0.4-rc02/tools/systemd/doris-fe.service) > or clickhouse > (https://github.com/ClickHouse/ClickHouse/blob/v25.8.13.73-lts/packages/clickhouse-server.service), > and change 'ExecStart' to the impala.sh script, thus we can reuse the same > logic with other bootstrap method, but the 'Type=forking' is discouraged. > > What do you think whether we should choose 'Type=exec' or 'Type=forking'? I think using 'Type=exec' is good. We can modify impala.sh to support not running the process in background. Then use that script in ExecStart= directly. The key point is that admins don't need to modify all the service unit files. All config files are consolidated together under /opt/impala/conf. http://gerrit.cloudera.org:8080/#/c/22742/1/package/etc/systemd/system/catalogd.service File package/etc/systemd/system/catalogd.service: http://gerrit.cloudera.org:8080/#/c/22742/1/package/etc/systemd/system/catalogd.service@33 PS1, Line 33: # Please replace '/usr/lib/jvm/java' with a valid jdk location > Maybe we should use EnvironmentFile=/opt/impala/conf/impala-env.sh and let Please ignore this. EnvironmentFile only supports simple KEY=VALUE in the file so can't use impala-env.sh here. -- To view, visit http://gerrit.cloudera.org:8080/22742 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73b3b3816ec7f1406c25f602ab5cb7c8e4ed571e Gerrit-Change-Number: 22742 Gerrit-PatchSet: 1 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Mon, 05 Jan 2026 08:29:37 +0000 Gerrit-HasComments: Yes
