Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23822 )
Change subject: IMPALA-14651: Fix flaky test_loaded_tables_metric due to report delay ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23822/1/tests/custom_cluster/test_automatic_invalidation.py File tests/custom_cluster/test_automatic_invalidation.py: http://gerrit.cloudera.org:8080/#/c/23822/1/tests/custom_cluster/test_automatic_invalidation.py@207 PS1, Line 207: Add extra buffer for metric updates and background processing. > I meant in total(15s + 1s buffer) Adding a buffer is harmless and fine. Just want to avoid confusing comments. I think 15s + 1s is enough. The table usage is recorded at the begining of the query (when metadata loading is triggered). Waiting for 15s after the query finished should be enough to make sure the usage is reported to catalogd. Adding 1s to make sure catalogd updates the metric. If you want to add a buffer, I think 1s is enough, e.g. for the RPC, serde, JNI overhead, etc. So I think 17s is OK. More importantly, please make sure the comments are clear. -- To view, visit http://gerrit.cloudera.org:8080/23822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a0a1df5a398a0c0d74c561a0a4b4a0defbac7a7 Gerrit-Change-Number: 23822 Gerrit-PatchSet: 1 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sun, 04 Jan 2026 06:15:03 +0000 Gerrit-HasComments: Yes
