Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22094 )
Change subject: IMPALA-13533: Calcite CTE backend ...................................................................... Patch Set 34: (2 comments) http://gerrit.cloudera.org:8080/#/c/22094/24//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22094/24//COMMIT_MSG@7 PS24, Line 7: IMPALA-13533: Calcite CTE backend > Needs some profile counters added, especially around LocalExchanger. Done http://gerrit.cloudera.org:8080/#/c/22094/34/be/src/runtime/local-exchanger.cc File be/src/runtime/local-exchanger.cc: http://gerrit.cloudera.org:8080/#/c/22094/34/be/src/runtime/local-exchanger.cc@63 PS34, Line 63: // consumer at the cost of keeping the last pushed RowBatch around after it's been read. This comment might not actually be true. We need to keep the last returned batch around until the next call to Pull so it's not deleted while being read. -- To view, visit http://gerrit.cloudera.org:8080/22094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48f16d495d4b37be97e6a913f0eb5b94d70e199a Gerrit-Change-Number: 22094 Gerrit-PatchSet: 34 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 31 Dec 2025 19:55:37 +0000 Gerrit-HasComments: Yes
