Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23679 )
Change subject: IMPALA-14525: Calcite planner: Add support for RexSimplify ...................................................................... Patch Set 7: Code-Review+1 (5 comments) http://gerrit.cloudera.org:8080/#/c/23679/6/fe/src/main/java/org/apache/impala/analysis/InPredicate.java File fe/src/main/java/org/apache/impala/analysis/InPredicate.java: http://gerrit.cloudera.org:8080/#/c/23679/6/fe/src/main/java/org/apache/impala/analysis/InPredicate.java@169 PS6, Line 169: boolean useSetLookup = isAllConstant && (children_.size() - 1 >= setLookupThreshold); > Not intentional. Great catch, thanks! Ack http://gerrit.cloudera.org:8080/#/c/23679/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexLiteralConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexLiteralConverter.java: http://gerrit.cloudera.org:8080/#/c/23679/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexLiteralConverter.java@98 PS6, Line 98: // Always treat all string literals as type STRING > This is just a bug that showed up. Ack http://gerrit.cloudera.org:8080/#/c/23679/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaInOperator.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaInOperator.java: http://gerrit.cloudera.org:8080/#/c/23679/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaInOperator.java@30 PS6, Line 30: private ImpalaInOperator() { > Done Ack http://gerrit.cloudera.org:8080/#/c/23679/6/testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q01.test File testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q01.test: http://gerrit.cloudera.org:8080/#/c/23679/6/testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q01.test@29 PS6, Line 29: Per-Host Resource Estimates: Memory=6.13GB > This was actually mentioned in the commit message already, but I only menti Ok, this does seem to bring it closer to https://github.com/apache/impala/blob/master/testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/tpcds-q01.test. http://gerrit.cloudera.org:8080/#/c/23679/6/testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q01.test@773 PS6, Line 773: | HDFS partitions=2003/2004 files=2003 size=48.12GB Interesting that somehow this managed to filter out a partition now. -- To view, visit http://gerrit.cloudera.org:8080/23679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44792688f361bf15affa565e5de5709f64dcf18c Gerrit-Change-Number: 23679 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 30 Dec 2025 18:03:01 +0000 Gerrit-HasComments: Yes
