Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23812 )
Change subject: IMPALA-14551: Fix hang on Unicode complex expressions in alias mapping ...................................................................... Patch Set 1: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23812/1/fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java File fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java: http://gerrit.cloudera.org:8080/#/c/23812/1/fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java@204 PS1, Line 204: assertTrue(ToSqlUtils.hiveNeedsQuotes("매출액 - lag(매출액) over (partition by x order by y)")); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/23812/1/fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java@206 PS1, Line 206: assertTrue(ToSqlUtils.hiveNeedsQuotes("sum(売上高) over (order by 年月日 rows unbounded preceding)")); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/23812/1/fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java@208 PS1, Line 208: assertTrue(ToSqlUtils.hiveNeedsQuotes("avg(销售额) over (order by 日期 rows between 3 preceding and current row)")); line too long (115 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I175de0c3cd958a03e5ca02590a8b84ca6e674f3d Gerrit-Change-Number: 23812 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 30 Dec 2025 13:40:03 +0000 Gerrit-HasComments: Yes
