Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23154 )
Change subject: IMPALA-9846: Enable Aggregated Runtime Profile by Default ...................................................................... Patch Set 22: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23154/22/be/src/util/runtime-profile.h File be/src/util/runtime-profile.h: http://gerrit.cloudera.org:8080/#/c/23154/22/be/src/util/runtime-profile.h@107 PS22, Line 107: Counter(TUnit::type unit, int64_t value = 0, TCounterCategory::type type = TCounterCategory::RAW) line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/23154/22/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/23154/22/be/src/util/runtime-profile.cc@2333 PS22, Line 2333: << PrettyPrinter::Print(BitcastToInt64(stats.total), unit_, true); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23154/22/common/thrift/RuntimeProfile.thrift File common/thrift/RuntimeProfile.thrift: http://gerrit.cloudera.org:8080/#/c/23154/22/common/thrift/RuntimeProfile.thrift@76 PS22, Line 76: 5: required TCounterCategory type Adding a required field 'type' in TAggCounter might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/23154/22/tests/util/workload_management.py File tests/util/workload_management.py: http://gerrit.cloudera.org:8080/#/c/23154/22/tests/util/workload_management.py@515 PS22, Line 515: i flake8: E501 line too long (110 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/23154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If41d6322361fba82c946efd614cc7d28cb1c36e8 Gerrit-Change-Number: 23154 Gerrit-PatchSet: 22 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Mon, 29 Dec 2025 21:31:26 +0000 Gerrit-HasComments: Yes
