Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23796 )
Change subject: IMPALA-14634: Organize custom cluster logs into subdirectories by test name ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/23796/3/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/23796/3/tests/common/custom_cluster_test_suite.py@605 PS3, Line 605: if os.environ.get("LOG_DIR"): This is fine. I would've been cute and used os.getenv os.getenv("LOG_DIR", os.getenv("IMPALA_CUSTOM_CLUSTER_TEST_LOGS_DIR", "/tmp/")) http://gerrit.cloudera.org:8080/#/c/23796/3/tests/common/custom_cluster_test_suite.py@624 PS3, Line 624: cls.impala_log_dir = impala_log_dir_per_test I'm not clear why this is stored to cls.impala_log_dir. It doesn't seem to be used outside this method. -- To view, visit http://gerrit.cloudera.org:8080/23796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a8402fed1584a99f91451a3976e7026d0deb834 Gerrit-Change-Number: 23796 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 19 Dec 2025 21:49:58 +0000 Gerrit-HasComments: Yes
