Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23797 )

Change subject: IMPALA-14628: Fix mismatch between greatest synced event time 
and last synced event time
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23797/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23797/1//COMMIT_MSG@19
PS1, Line 19: a mismatch
nit: add a period.


http://gerrit.cloudera.org:8080/#/c/23797/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
File 
fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java:

http://gerrit.cloudera.org:8080/#/c/23797/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@4381
PS1, Line 4381:     Thread.sleep(1000);
Could you add a comment on why we need this sleep?



--
To view, visit http://gerrit.cloudera.org:8080/23797
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26550441bc0d5e7736c3b900c3e5178103157446
Gerrit-Change-Number: 23797
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Thu, 18 Dec 2025 01:58:48 +0000
Gerrit-HasComments: Yes

Reply via email to