Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22094 )
Change subject: IMPALA-13533: Calcite CTE backend ...................................................................... Patch Set 25: (2 comments) http://gerrit.cloudera.org:8080/#/c/22094/25/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/22094/25/be/src/scheduling/scheduler.cc@1123 PS25, Line 1123: // TODO: implies multiple CTE consumers under a union requires their producers This no longer applies, unions are handled elsewhere. http://gerrit.cloudera.org:8080/#/c/22094/25/be/src/scheduling/scheduler.cc@1141 PS25, Line 1141: ? GetFirstProducer(fragment_state, state) I don't fully understand why this was necessary, I would have thought the CTE would always appear on the probe side of a hash join (build side would go through an exchange). Where I would interpret "left-most" as meaning the probe side. -- To view, visit http://gerrit.cloudera.org:8080/22094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48f16d495d4b37be97e6a913f0eb5b94d70e199a Gerrit-Change-Number: 22094 Gerrit-PatchSet: 25 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 16 Dec 2025 19:39:01 +0000 Gerrit-HasComments: Yes
