Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23775 )
Change subject: IMPALA-14611: completed_queries in ExecLoadIcebergDataRequestImpl is never freed ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/23775/3/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/23775/3/be/src/service/client-request-state.cc@1018 PS3, Line 1018: vector<ChildQuery*> completed_queries; completed_queries is an output of WaitForAll. It's a little weird we don't seem to use that anywhere. I don't ever see the output of WaitForAll used. Could we remove the vector arg instead? -- To view, visit http://gerrit.cloudera.org:8080/23775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I058da5f9ddc1b36ff4e5392ecbdd6699e9789a58 Gerrit-Change-Number: 23775 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Tue, 16 Dec 2025 17:06:50 +0000 Gerrit-HasComments: Yes
