Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23792
Change subject: IMPALA-13607, IMPALA-14490: Deflake test_cache_valid_on_nontransactional_table_ddls ...................................................................... IMPALA-13607, IMPALA-14490: Deflake test_cache_valid_on_nontransactional_table_ddls When catalogd runs with --start_hms_server=true, it services all the HMS endpoints so that any HMS compatible client would be able to use catalogd as a metadata cache. For all the DDL/DML requests, catalogd just delegates them to HMS APIs without reloading related metadata in the cache. For read requests like get_table_req, catalogd serves them from its cache which could be stale. There is a flag, invalidate_hms_cache_on_ddls, to decide whether to explicitly invalidate the table when catalogd delegates a DDL/DML on the table to HMS. test_cache_valid_on_nontransactional_table_ddls is a test verifying that when invalidate_hms_cache_on_ddls=false, the cache is not updated so should have stale metadata. However, there are HMS events generated from invoking the HMS APIs. Even when invalidate_hms_cache_on_ddls=false, catalogd can still update its cache when processing the corresponding HMS events. The test fails when its check is done after catalogd applies the event (so the cache is up-to-date). If the check is done before that, the test passes. This patch deflakes the test by explicitly disabling event processing. Also updates the description of invalidate_hms_cache_on_ddls to mention the impact of event processing. Tests: - Ran the test locally 100 times. Change-Id: Ib1ffc11a793899a0dbdb009bf2ac311117f2318e --- M be/src/catalog/catalog-server.cc M tests/custom_cluster/test_metastore_service.py 2 files changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/23792/1 -- To view, visit http://gerrit.cloudera.org:8080/23792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib1ffc11a793899a0dbdb009bf2ac311117f2318e Gerrit-Change-Number: 23792 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]>
