Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22091 )
Change subject: IMPALA-13531: Calcite CTE frontend ...................................................................... Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/22091/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaSequence.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaSequence.java: http://gerrit.cloudera.org:8080/#/c/22091/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaSequence.java@39 PS14, Line 39: private final List<RelNode> inputs_; > Ok, I'm thinking through this a bit more... I'm still not clear what's special about how ImpalaSequence holds inputs. It implements the same overrides that e.g. https://github.com/apache/calcite/blob/main/core/src/main/java/org/apache/calcite/rel/rules/MultiJoin.java does. Are you saying specifically because it's not one of the known core RelNode implementations, Calcite will treat it differently instead of using getInputs, replaceInput, and copy? HepPlanner calls copy and replaceInput on ImpalaSequence during runPreImpalaConvertProgram. -- To view, visit http://gerrit.cloudera.org:8080/22091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0840c0859d2fe25628d799a18d302cee1eb36e8 Gerrit-Change-Number: 22091 Gerrit-PatchSet: 15 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 15 Dec 2025 17:28:19 +0000 Gerrit-HasComments: Yes
