Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23763 )
Change subject: IMPALA-14605: Fix memory leak in global admissiond for cancelled queued queries ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/23763/3/be/src/scheduling/admissiond-env.cc File be/src/scheduling/admissiond-env.cc: http://gerrit.cloudera.org:8080/#/c/23763/3/be/src/scheduling/admissiond-env.cc@139 PS3, Line 139: admission_controller_->RegisterAdmissionMapCleanupCallback( : [&](const UniqueIdPB& query_id) { : admission_control_svc_->CleanupAdmissionStateMapAsync(query_id); : }); Is the cleanup thread only registered in case of dedicated AC service? Why embedded admission-control does not need the same cleanup thread? http://gerrit.cloudera.org:8080/#/c/23763/3/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/23763/3/tests/custom_cluster/test_admission_controller.py@2426 PS3, Line 2426: start_args="--enable_admission_service", This flag is not needed. self.enable_admission_service(method) in L2109 already append this. -- To view, visit http://gerrit.cloudera.org:8080/23763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f16f3cf986e2038d6486d3ec687135d561e2cbf Gerrit-Change-Number: 23763 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 15 Dec 2025 16:57:53 +0000 Gerrit-HasComments: Yes
