Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23747 )
Change subject: Guard against null getDistinctRowCount ...................................................................... Patch Set 2: Do you have a query where this happens? The reason I ask: IIRC, I saw this problem when I originally released the code and I had these guards in place. But after a comment in the code review, I researched it and I was able to change the code that returned the nulls. The guard might be a good thing anyway? But if it's something going haywire in our code returning nulls (or our code doing something to force Calcite to return nulls), we might want to fix it there. I can do the research on that since I know you're busy on other things. -- To view, visit http://gerrit.cloudera.org:8080/23747 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I657b3431011a3dddbfc3fe7a6519980f78966261 Gerrit-Change-Number: 23747 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 10 Dec 2025 15:47:22 +0000 Gerrit-HasComments: No
