Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO ...................................................................... Patch Set 6: (1 comment) After fixing the identation in AnalyzeStmtsTest.java, it's good to go for me. http://gerrit.cloudera.org:8080/#/c/23721/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/23721/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@5224 PS6, Line 5224: AnalyzesOk("alter table functional_parquet.tinytable convert to iceberg" : + " tblproperties('format-version'='1')"); : AnalyzesOk("alter table functional_parquet.tinytable convert to iceberg" : + " tblproperties('format-version'='2')"); : AnalysisError("alter table functional_parquet.tinytable convert to iceberg" : + " tblproperties('format-version'='3')", : "Unsupported Iceberg format version '3'"); : AnalysisError("alter table functional_parquet.tinytable convert to iceberg" : + " tblproperties('format-version'='unknown')", : "Invalid Iceberg format version 'unknown'"); : AnalysisError("alter table functional_parquet.tinytable convert to iceberg" : + " tblproperties('metadata.generator.threads'='a1')", : "CONVERT TO ICEBERG doesn't accept 'metadata.generator.threads' as TBLPROPERTY."); Identation is off by 2 spaces. -- To view, visit http://gerrit.cloudera.org:8080/23721 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865 Gerrit-Change-Number: 23721 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Mon, 08 Dec 2025 10:06:40 +0000 Gerrit-HasComments: Yes
