Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22091 )
Change subject: IMPALA-13531: Calcite CTE frontend ...................................................................... Patch Set 12: (5 comments) http://gerrit.cloudera.org:8080/#/c/22091/7/fe/src/main/java/org/apache/impala/planner/CTEScanNode.java File fe/src/main/java/org/apache/impala/planner/CTEScanNode.java: http://gerrit.cloudera.org:8080/#/c/22091/7/fe/src/main/java/org/apache/impala/planner/CTEScanNode.java@59 PS7, Line 59: desc.getSlots().stream().allMatch(SlotDescriptor::isMaterialized)); > Also seems to be unused. LOG was removed, so no longer an issue. http://gerrit.cloudera.org:8080/#/c/22091/10/fe/src/main/java/org/apache/impala/planner/SequenceNode.java File fe/src/main/java/org/apache/impala/planner/SequenceNode.java: http://gerrit.cloudera.org:8080/#/c/22091/10/fe/src/main/java/org/apache/impala/planner/SequenceNode.java@53 PS10, Line 53: assignConjuncts(analyzer); > If SequenceNode is at the top, will there be any conjuncts to assign? I wo It might not be necessary. The preconditions is asserting there are none. This is an area where the patterns are not as clear as I'd like. http://gerrit.cloudera.org:8080/#/c/22091/10/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/22091/10/fe/src/main/java/org/apache/impala/service/Frontend.java@169 PS10, Line 169: import org.apache.impala.hooks.QueryEventHookManager; > Nit: Unused Done http://gerrit.cloudera.org:8080/#/c/22091/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/cte/Exception.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/cte/Exception.java: http://gerrit.cloudera.org:8080/#/c/22091/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/cte/Exception.java@21 PS7, Line 21: > Gonna nit this one because I can see the argument that since it's already u Done http://gerrit.cloudera.org:8080/#/c/22091/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/cte/Registry.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/cte/Registry.java: http://gerrit.cloudera.org:8080/#/c/22091/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/cte/Registry.java@39 PS7, Line 39: private final Map<String, RelNode> ctes_ = new HashMap<>(); > Nit: ctes_ Done -- To view, visit http://gerrit.cloudera.org:8080/22091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0840c0859d2fe25628d799a18d302cee1eb36e8 Gerrit-Change-Number: 22091 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 03 Dec 2025 04:46:46 +0000 Gerrit-HasComments: Yes
