Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO ...................................................................... Patch Set 1: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23721/1/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java File fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java: http://gerrit.cloudera.org:8080/#/c/23721/1/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java@128 PS1, Line 128: throw new AnalysisException(String.format("Unsupported Iceberg format version '%s'.", formatVersion)); line too long (118 > 90) http://gerrit.cloudera.org:8080/#/c/23721/1/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java@130 PS1, Line 130: throw new AnalysisException(String.format("Invalid Iceberg format version '%s'.", value)); line too long (106 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23721 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865 Gerrit-Change-Number: 23721 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Mon, 01 Dec 2025 12:20:32 +0000 Gerrit-HasComments: Yes
