Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23691 )
Change subject: IMPALA-14434: Calcite planner: implement partition key scan optimization ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23691/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java: http://gerrit.cloudera.org:8080/#/c/23691/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java@122 PS1, Line 122: SingleNodePlanner.createOptimizedPartitionUnionNode(nodeId, impalaPartitions, > Why is this (and createAcidJoinNode) part of SingleNodePlanner rather than SingleNodePlanner is part of the original planner and both of these methods are also called by the original planner. Whereas NodeCreationUtils is specific to Calcite. Would a rename here be better for NodeCreationUtils? Or perhaps I should move those methods out of SingleNodePlanner into some kind of static shared class to lighten the amount of code in SingleNodePlanner? -- To view, visit http://gerrit.cloudera.org:8080/23691 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b5b8a8115f65f6be27a5be0e19f21eebab61a32 Gerrit-Change-Number: 23691 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 27 Nov 2025 21:12:10 +0000 Gerrit-HasComments: Yes
