Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23719 )
Change subject: WIP IMPALA-14576, IMPALA-14577: add rewrit rules for geospatial relations ...................................................................... Patch Set 1: (5 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23719/1/fe/src/main/java/org/apache/impala/rewrite/AddEnvIntersectsRule.java File fe/src/main/java/org/apache/impala/rewrite/AddEnvIntersectsRule.java: http://gerrit.cloudera.org:8080/#/c/23719/1/fe/src/main/java/org/apache/impala/rewrite/AddEnvIntersectsRule.java@40 PS1, Line 40: * line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23719/1/fe/src/main/java/org/apache/impala/rewrite/AddEnvIntersectsRule.java@46 PS1, Line 46: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23719/1/fe/src/main/java/org/apache/impala/rewrite/PointEnvIntersectsRule.java File fe/src/main/java/org/apache/impala/rewrite/PointEnvIntersectsRule.java: http://gerrit.cloudera.org:8080/#/c/23719/1/fe/src/main/java/org/apache/impala/rewrite/PointEnvIntersectsRule.java@53 PS1, Line 53: Expr constChild = expr.getChild(0); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23719/1/fe/src/main/java/org/apache/impala/rewrite/PointEnvIntersectsRule.java@62 PS1, Line 62: if (pointFn.getChildCount() != 2 line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23719/1/fe/src/main/java/org/apache/impala/rewrite/PointEnvIntersectsRule.java@63 PS1, Line 63: || !pointFn.getChild(0).getType().isFloatingPointType() line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/23719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id65f646db6f1c89a74253e9ff755c39c400328be Gerrit-Change-Number: 23719 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 26 Nov 2025 16:25:36 +0000 Gerrit-HasComments: Yes
