Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23714 )
Change subject: IMPALA-13941: Add helper to format file permissions as UNIX-style string ...................................................................... Patch Set 1: (5 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23714/1/tests/custom_cluster/test_logging.py File tests/custom_cluster/test_logging.py: http://gerrit.cloudera.org:8080/#/c/23714/1/tests/custom_cluster/test_logging.py@23 PS1, Line 23: import stat flake8: F401 'stat' imported but unused http://gerrit.cloudera.org:8080/#/c/23714/1/tests/custom_cluster/test_logging.py@163 PS1, Line 163: r flake8: F841 local variable 'result' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/23714/1/tests/custom_cluster/test_logging.py@191 PS1, Line 191: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23714/1/tests/custom_cluster/test_logging.py@217 PS1, Line 217: e flake8: E722 do not use bare 'except' http://gerrit.cloudera.org:8080/#/c/23714/1/tests/custom_cluster/test_logging.py@218 PS1, Line 218: ! flake8: E501 line too long (93 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/23714 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib53dbecd5c202e33b6e3b5cd3a372a77d8b1703a Gerrit-Change-Number: 23714 Gerrit-PatchSet: 1 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 25 Nov 2025 13:47:49 +0000 Gerrit-HasComments: Yes
