Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22926 )
Change subject: IMPALA-14574: Lower memory estimate by analyzing PipelineMembership ...................................................................... Patch Set 6: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22926/6/fe/src/main/java/org/apache/impala/planner/PipelineBasedMemEstimator.java File fe/src/main/java/org/apache/impala/planner/PipelineBasedMemEstimator.java: http://gerrit.cloudera.org:8080/#/c/22926/6/fe/src/main/java/org/apache/impala/planner/PipelineBasedMemEstimator.java@98 PS6, Line 98: "tracing max resource at fragment {} with fragmentMemGrowth={} and minMemEstimate={}", line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22926/6/fe/src/main/java/org/apache/impala/planner/PipelineBasedMemEstimator.java@218 PS6, Line 218: "Adding max(openPipeMemGrowth={}, openMaxMemGrowth={}) from collocated openPipe {} to " line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/22926/6/fe/src/main/java/org/apache/impala/planner/PipelineBasedMemEstimator.java@230 PS6, Line 230: "At node {} pipeline[{}], compare current ({}) vs adjacent ({}) vs totalMaxAtOpen ({})", line too long (102 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba4f40993d8360bfdc1eb592a626e285dfed1627 Gerrit-Change-Number: 22926 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 24 Nov 2025 18:47:00 +0000 Gerrit-HasComments: Yes
