ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala ...................................................................... Patch Set 112: (4 comments) http://gerrit.cloudera.org:8080/#/c/21760/111/bin/create-test-configuration.sh File bin/create-test-configuration.sh: http://gerrit.cloudera.org:8080/#/c/21760/111/bin/create-test-configuration.sh@204 PS111, Line 204: ${CLASSPATH} > I think this is a typo. It should be ${CLASSPATH}. But it seems the CLASSPA Done http://gerrit.cloudera.org:8080/#/c/21760/111/fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/21760/111/fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java@100 PS111, Line 100: Apache Hive 2 > nit: "Apache Hive 2"? Done http://gerrit.cloudera.org:8080/#/c/21760/111/fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java@188 PS111, Line 188: /** : * Wrapper around HMS-3 message serializer : * @param message : * @return serialized string to use used in the NotificationEvent's message field : */ : @VisibleForTesting : public static String serializeEventMessage(EventMessage message) { : return message.toString(); : } : > nit: Please remove these if we don't need them. Done http://gerrit.cloudera.org:8080/#/c/21760/111/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java File fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java: http://gerrit.cloudera.org:8080/#/c/21760/111/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java@284 PS111, Line 284: List<Stri > nit: use the generic type List in definition. Done -- To view, visit http://gerrit.cloudera.org:8080/21760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c Gerrit-Change-Number: 21760 Gerrit-PatchSet: 112 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Mon, 24 Nov 2025 15:57:14 +0000 Gerrit-HasComments: Yes
