Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21665 )
Change subject: IMPALA-12865: Fix wrong lastRefreshEventId set by firing RELOAD events ...................................................................... Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/21665/20/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21665/20/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7576 PS20, Line 7576: catalog_.addVersionsForInflightEvents(false, tbl, newCatalogVersion); > I get what you are suggesting but in order to that we need metastore side c In the constructor of ReloadEvent, we get a Partition object for partition-level RELOAD. Can we use it? https://github.com/apache/impala/blob/f12bb87d421bd197ad27da9686a138db84a4bcc3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java#L3425 On the other hand, partition-level constructor of SelfEventContext needs a List<TPartitionKeyValue> which is very simple to construct. Each TPartitionKeyValue is just a string pair of (name, value). Constructing it from HMS Partition object is a convenient way. But I don't think it's hard to construct it based on partition names. So I don't think we need HMS side changes. Or did I missing something? -- To view, visit http://gerrit.cloudera.org:8080/21665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90039da77ec561c5aede44456f88c6650582815b Gerrit-Change-Number: 21665 Gerrit-PatchSet: 21 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 24 Nov 2025 03:01:41 +0000 Gerrit-HasComments: Yes
