Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23698 )
Change subject: IMPALA-9509: Add array_contains() for primitive types ...................................................................... Patch Set 1: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23698/1/be/src/exprs/collection-functions-ir.cc File be/src/exprs/collection-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/23698/1/be/src/exprs/collection-functions-ir.cc@63 PS1, Line 63: ctx->SetError("Failed to resolve collection item tuple descriptor for array_contains."); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23698/1/be/src/exprs/scalar-expr-evaluator.cc File be/src/exprs/scalar-expr-evaluator.cc: http://gerrit.cloudera.org:8080/#/c/23698/1/be/src/exprs/scalar-expr-evaluator.cc@458 PS1, Line 458: CollectionFunctions::ArrayContainsTinyInt(nullptr, CollectionVal::null(), TinyIntVal::null()); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/23698/1/fe/src/main/java/org/apache/impala/catalog/StructType.java File fe/src/main/java/org/apache/impala/catalog/StructType.java: http://gerrit.cloudera.org:8080/#/c/23698/1/fe/src/main/java/org/apache/impala/catalog/StructType.java@136 PS1, Line 136: if (!fields_.get(i).getType().matchesType(otherStructType.fields_.get(i).getType())) { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23698/1/tests/query_test/test_array_contains.py File tests/query_test/test_array_contains.py: http://gerrit.cloudera.org:8080/#/c/23698/1/tests/query_test/test_array_contains.py@29 PS1, Line 29: class TestArrayContains(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/23698 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I751cc9f6c7f785f5269c7203fd753ec9aa2a9e78 Gerrit-Change-Number: 23698 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 20 Nov 2025 06:14:12 +0000 Gerrit-HasComments: Yes
