Hello Joe McDonnell, Steve Carlin, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22093
to look at the new patch set (#9).
Change subject: IMPALA-13532: Improved concurrent BufferedTupleStream
......................................................................
IMPALA-13532: Improved concurrent BufferedTupleStream
Enhancements to BufferedTupleStream to support concurrent reading
without pinning all pages. Calling DoneWriting enables a concurrent mode
where pin/unpin operations are guarded by a mutex, so multiple
ReadIterators can read different pages simultaneously.
Marks const methods in RowBatch to simplify RowBatch handling.
TODO:
- release extra memory reservation when a ReadIterator is done
- clean up mixed read/write vs concurrent read logic
- create benchmark for concurrent reads
Change-Id: Ie2130844613eb9f77f13d31f2c0d5e65cb063736
---
M be/src/exec/partitioned-hash-join-node.cc
M be/src/runtime/buffered-tuple-stream-test.cc
M be/src/runtime/buffered-tuple-stream.cc
M be/src/runtime/buffered-tuple-stream.h
M be/src/runtime/row-batch.cc
M be/src/runtime/row-batch.h
6 files changed, 230 insertions(+), 126 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/22093/9
--
To view, visit http://gerrit.cloudera.org:8080/22093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie2130844613eb9f77f13d31f2c0d5e65cb063736
Gerrit-Change-Number: 22093
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>