Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23560 )
Change subject: IMPALA-14421: Calcite planner: case statement returning wrong types for char, varchar ...................................................................... Patch Set 7: Code-Review+1 (3 comments) Looks OK to me. I can +2 if no one else has concern. http://gerrit.cloudera.org:8080/#/c/23560/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java: http://gerrit.cloudera.org:8080/#/c/23560/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@49 PS5, Line 49: > Done Done http://gerrit.cloudera.org:8080/#/c/23560/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/FunctionResolver.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/FunctionResolver.java: http://gerrit.cloudera.org:8080/#/c/23560/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/FunctionResolver.java@189 PS5, Line 189: : /** : * getSpecialProcessingFunction handles functions th > Done Done http://gerrit.cloudera.org:8080/#/c/23560/5/testdata/workloads/functional-query/queries/QueryTest/calcite.test File testdata/workloads/functional-query/queries/QueryTest/calcite.test: http://gerrit.cloudera.org:8080/#/c/23560/5/testdata/workloads/functional-query/queries/QueryTest/calcite.test@1136 PS5, Line 1136: ERY > Done Done -- To view, visit http://gerrit.cloudera.org:8080/23560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82d657f4bfce432c458ee8198188dadf9f23f2ef Gerrit-Change-Number: 23560 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 17 Nov 2025 20:43:09 +0000 Gerrit-HasComments: Yes
