Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23626 )
Change subject: IMPALA-9715: Load testdata with Impala ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/23626/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23626/12//COMMIT_MSG@19 PS12, Line 19: Moves most table data under testdata/data to simplify uploads. : functional-query data now live in testdata/data and testdata/target (for : generated data). I totally agree with this change, but it would be nicer to move it to a separate commit. http://gerrit.cloudera.org:8080/#/c/23626/12/testdata/datasets/tpcds/tpcds_schema_template.sql File testdata/datasets/tpcds/tpcds_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/23626/12/testdata/datasets/tpcds/tpcds_schema_template.sql@43 PS12, Line 43: ---- LOAD : LOAD DATA INPATH '{impala_home}/testdata/impala-data/{db_name}/time_dim/' : OVERWRITE INTO TABLE {db_name}{db_suffix}.{table_name}; In most tables the exact same pattern is used (time_dim is also {table_name}) - it would be nice to clean up this redundancy. E.g. a section like ---- LOAD_SIMPLE could be used to load the data from {impala_home}/testdata/impala-data/{db_name}/{table_name}/ to {db_name}{db_suffix}.{table_name}. This section could be also implemented by copying the files directly with hdfs without the load data. I see many table though where the two are slightly different in 'functional', e.g. hive2_bad_avro_date_pre_gregorian vs testdata/bad_avro_snap/hive2_pre_gregorian_date.avro or liketbl vs LikeTbl -- To view, visit http://gerrit.cloudera.org:8080/23626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d681a89d49fde9562ea67fd250fad2edd308ae Gerrit-Change-Number: 23626 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 17 Nov 2025 16:27:35 +0000 Gerrit-HasComments: Yes
