Hello Quanlong Huang, Zoltan Borok-Nagy, Peter Rozsa, Noemi Pap-Takacs, Impala
Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23514
to look at the new patch set (#11).
Change subject: IMPALA-12209: Always include format-version in DESCRIBE
FORMATTED and SHOW CREATE TABLE for Iceberg tables
......................................................................
IMPALA-12209: Always include format-version in DESCRIBE FORMATTED and SHOW
CREATE TABLE for Iceberg tables
HiveCatalog does not include format-version for Iceberg tables in the
table's parameters, therefore the output of SHOW CREATE TABLE may not
replicate the original table.
This patch makes sure to add it to both the SHOW CREATE TABLE and
DESCRIBE FORMATTED/EXTENDED output.
Additionally, adds ICEBERG_DEFAULT_FORMAT_VERSION variable to E2E
tests, deducting from IMPALA_ICEBERG_VERSION environment variable.
If Iceberg version is at least 1.4, default format-version is 2, before
1.4 it's 1. This way tests can work with multiple Iceberg versions.
Testing:
* updated show-create-table.test for Iceberg tables
* added format-version checks to multiple DESCRIBE FORMATTED tests
Change-Id: I991edf408b24fa73e8a8abe64ac24929aeb8e2f8
---
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/service/DescribeResultFactory.java
M
testdata/workloads/functional-query/queries/QueryTest/iceberg-alter-default.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter-v1.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter-v2.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-catalogs.test
M
testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-table.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-external.test
M
testdata/workloads/functional-query/queries/QueryTest/iceberg-migrate-from-external-hdfs-tables.test
M
testdata/workloads/functional-query/queries/QueryTest/iceberg-missing-data-files.test
M
testdata/workloads/functional-query/queries/QueryTest/iceberg-old-fileformat.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test
M
testdata/workloads/functional-query/queries/QueryTest/iceberg-rest-catalog.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-rest-fgac.test
M testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
M tests/common/environ.py
M tests/common/impala_test_suite.py
M tests/metadata/test_show_create_table.py
20 files changed, 235 insertions(+), 72 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/23514/11
--
To view, visit http://gerrit.cloudera.org:8080/23514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I991edf408b24fa73e8a8abe64ac24929aeb8e2f8
Gerrit-Change-Number: 23514
Gerrit-PatchSet: 11
Gerrit-Owner: Daniel Vanko <[email protected]>
Gerrit-Reviewer: Daniel Vanko <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
