Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23637 )
Change subject: IMPALA-14525: Calcite planner: Add support for RexSimplify ...................................................................... Patch Set 11: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23637/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedInPredicate.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedInPredicate.java: http://gerrit.cloudera.org:8080/#/c/23637/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedInPredicate.java@40 PS11, Line 40: protected static final Logger LOG = LoggerFactory.getLogger(AnalyzedInPredicate.class.getName()); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/23637/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/CreateExprVisitor.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/CreateExprVisitor.java: http://gerrit.cloudera.org:8080/#/c/23637/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/CreateExprVisitor.java@150 PS11, Line 150: RexNode expandedOperand = ImpalaRexUtil.expandSearch(visitor.getRexBuilder(), operand); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/23637/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaFilterSimplifyRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaFilterSimplifyRule.java: http://gerrit.cloudera.org:8080/#/c/23637/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaFilterSimplifyRule.java@58 PS11, Line 58: Filter newFilter = filter.copy(filter.getTraitSet(), filter.getInput(0), newCondition); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23637 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id626bba49467f121ce57215040b48d4a277f9e50 Gerrit-Change-Number: 23637 Gerrit-PatchSet: 11 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sun, 16 Nov 2025 21:46:57 +0000 Gerrit-HasComments: Yes
