Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23562 )
Change subject: IMPALA-13902: Calcite planner: Implement is_spool_query_results ...................................................................... Patch Set 20: (2 comments) Lets wait until https://gerrit.cloudera.org/c/23673/1 merged. http://gerrit.cloudera.org:8080/#/c/23562/19/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java File fe/src/main/java/org/apache/impala/planner/PlanRootSink.java: http://gerrit.cloudera.org:8080/#/c/23562/19/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java@237 PS19, Line 237: > This should be Done http://gerrit.cloudera.org:8080/#/c/23562/19/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java@311 PS19, Line 311: = Math.max(maxSpoolingMem_, minMemReservationBytes_ > This clause should be removed. L313 is the correct place for it. Done -- To view, visit http://gerrit.cloudera.org:8080/23562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b9bf49e2874ee12de212b892bd898c296774c6f Gerrit-Change-Number: 23562 Gerrit-PatchSet: 20 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sat, 15 Nov 2025 18:46:59 +0000 Gerrit-HasComments: Yes
