Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23627 )
Change subject: IMPALA-14553: Run schema eval concurrently ...................................................................... Patch Set 15: Code-Review+2 (1 comment) Carrying +2 for minor rename. http://gerrit.cloudera.org:8080/#/c/23627/14/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/23627/14/testdata/bin/generate-schema-statements.py@843 PS14, Line 843: # later. : def fails_only_constraint(table_name, table_format): : constraint = schema_only_constraints.get(table_format) : return constraint is not None and table_name not in constraint : : def fails_include_constraint(table_name, table_format): : constraint = schema_include_constraints.get(table_name) : return constraint is not None and table_format not in constraint : : def fails_exclude_constraint(table_name, table_format): : constraint = schema_exclude_constraints.get(table_name) > Nit: For some of these, the direction of the name vs what it's testing can Done -- To view, visit http://gerrit.cloudera.org:8080/23627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a78d05fd6a0005c83561978713237da2dde6af2 Gerrit-Change-Number: 23627 Gerrit-PatchSet: 15 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 15 Nov 2025 06:12:35 +0000 Gerrit-HasComments: Yes
