Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23627 )
Change subject: IMPALA-14553: Run schema eval concurrently ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/23627/12/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/23627/12/testdata/bin/generate-schema-statements.py@735 PS12, Line 735: """section_str should be the contents of a section (i.e. a string). If section_str : starts with `, evaluates section_str as a shell command in pool and returns an : AsyncResult to produce the output. Otherw > Please add some comments about the new thread pool method and its implicati Done http://gerrit.cloudera.org:8080/#/c/23627/12/testdata/bin/generate-schema-statements.py@773 PS12, Line 773: > nit: list() Done http://gerrit.cloudera.org:8080/#/c/23627/12/testdata/bin/generate-schema-statements.py@779 PS12, Line 779: E_ > Are we safe to use python f string now, or is it better to use older way of This file specifically runs with impala-python3, so we control the version. Also Python 3.6 is considered ancient now, I think it's generally safe to use features from it. http://gerrit.cloudera.org:8080/#/c/23627/12/testdata/bin/generate-schema-statements.py@831 PS12, Line 831: pool.close() > Is it possible to unwrap and close the thread pool early here? Done. Had to add a bit of special handling on unwrap so later code still recognized when a section was set if it's eval result returned an empty string. -- To view, visit http://gerrit.cloudera.org:8080/23627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a78d05fd6a0005c83561978713237da2dde6af2 Gerrit-Change-Number: 23627 Gerrit-PatchSet: 13 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 14 Nov 2025 17:28:45 +0000 Gerrit-HasComments: Yes
