Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23562 )
Change subject: IMPALA-13902: Calcite planner: Implement is_spool_query_results ...................................................................... Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/23562/10/fe/src/main/java/org/apache/impala/analysis/QueryStmt.java File fe/src/main/java/org/apache/impala/analysis/QueryStmt.java: http://gerrit.cloudera.org:8080/#/c/23562/10/fe/src/main/java/org/apache/impala/analysis/QueryStmt.java@505 PS10, Line 505: * Planner can still decide to disable result spooling if there are other factors > nit: factors Done http://gerrit.cloudera.org:8080/#/c/23562/10/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java File fe/src/main/java/org/apache/impala/planner/PlanRootSink.java: http://gerrit.cloudera.org:8080/#/c/23562/10/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java@113 PS10, Line 113: @Override > Can we just set resourceProfile_ to estProfile? Removed in patch set 13. http://gerrit.cloudera.org:8080/#/c/23562/12/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java File fe/src/main/java/org/apache/impala/planner/PlanRootSink.java: http://gerrit.cloudera.org:8080/#/c/23562/12/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java@168 PS12, Line 168: // Check if we need to disable result spooling because we can not spill. > Optional: Gonna +1 this, but we talked offline about this, but I figured I Extracted out the memory bounding calculation to helper class SpoolingMemoryBound. This ensure consistent formula when two calculation happen separately in sanitizeSpoolingOptions() and computeResourceProfile(). -- To view, visit http://gerrit.cloudera.org:8080/23562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b9bf49e2874ee12de212b892bd898c296774c6f Gerrit-Change-Number: 23562 Gerrit-PatchSet: 13 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 14 Nov 2025 16:29:07 +0000 Gerrit-HasComments: Yes
