Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3 ...................................................................... Patch Set 29: (3 comments) http://gerrit.cloudera.org:8080/#/c/21724/29/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/21724/29/bin/impala-config.sh@426 PS29, Line 426: If someone uses USE_APACHE_HIVE=true, do we wanna have a fallback with a warning in order to prevent build failures? http://gerrit.cloudera.org:8080/#/c/21724/29/bin/impala-config.sh@446 PS29, Line 446: hive-3 nit: Shouldn't this be hive-3.x? http://gerrit.cloudera.org:8080/#/c/21724/29/common/function-registry/CMakeLists.txt File common/function-registry/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/21724/29/common/function-registry/CMakeLists.txt@64 PS29, Line 64: nit: remove space -- To view, visit http://gerrit.cloudera.org:8080/21724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d Gerrit-Change-Number: 21724 Gerrit-PatchSet: 29 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Tue, 11 Nov 2025 02:52:42 +0000 Gerrit-HasComments: Yes
